• 【C++】记录一次代码优化，28490行代码优化到1401行代码


    优化背景，游戏需要做一个旁观功能，那么需要修改的地方有入座和广播。目前看代码是有110个麻将和牌类，代码相似度99.9%，只有一个枚举不一样(游戏id).
    功能是很简单，入座的协议加个字段是否旁边，广播的时候给旁边的玩家也发消息。但是涉及到一百多个游戏，我也可以每个游戏都改一遍，但是如果有bug，或者还需要修改，不是很麻烦吗。
    所以必须把相同的代码抽出来形成通用函数，每个游戏调用通用函数，不一样的再特殊处理。


    接收消息的地方只有一行代码不一样，游戏id

    每个游戏都有一个 CommonClienthandler.cpp

    1. ENHandlerResult CRequestEnterTable::ProcessUpdateSucc(CHandlerTokenBasic* ptoken, CSession* psession)
    2. {
    3.     if (psession->_fsm_state == EN_EnterTable_State_ULOCK)
    4.     {
    5.         PBCSMsg msg;
    6.         CSResponseDssEnterTable& response = *msg.mutable_cs_response_dss_enter_table();
    7.         response.set_result(EN_MESSAGE_TABLE_NOT_EXIST);
    8.         Message::SendResponseMsg(RouteManager::Instance()->GetRouteByRandom(), psession, msg);
    9.         return EN_Handler_Done;
    10.     }
    11.     else if (psession->_fsm_state == EN_EnterTable_State_ULOCK_AF_SAVE)
    12.     {
    13.         PBCSMsg msg;
    14.         CSResponseEnterTable& response = *msg.mutable_cs_response_enter_table();
    15.         response.set_result(EN_MESSAGE_NO_EMPTY_SEAT);
    16.         Message::SendResponseMsg(RouteManager::Instance()->GetRouteByRandom(), psession, msg);
    17.         return EN_Handler_Done;
    18.     }
    19.     long long uid = psession->_request_route.uid();
    20.     const PBUser& user = psession->_kvdb_uid_data_map[uid].user_info();
    21.     const CSRequestDssEnterTable& cs_request_enter_table = psession->_request_msg.cs_request_dss_enter_table();
    22.     int tid = cs_request_enter_table.tid();
    23.     int connect_id = cs_request_enter_table.connect_id();
    24.     PBCSMsg msg;
    25.     CSResponseDssEnterTable& response = *msg.mutable_cs_response_dss_enter_table();
    26. //    const PBBPlayerPositionInfo & pos = user.pos();
    27. //    if(pos.pos_type() == EN_Position_DSS_Xj && pos.table_id() != 0)
    28. //    {
    29. //        tid = pos.table_id();
    30. //    }
    31.     CPBGameTable* ptable = TableManager::Instance()->FindTable(tid);
    32.     if (ptable == NULL)
    33.     {
    34.         return EN_Handler_Done;
    35.     }
    36.     PBDSSTableSeat* pseat = TableLogic::FindEmptySeatInTable(*ptable);
    37.     if (pseat == NULL)
    38.     {
    39.         psession->_fsm_state = EN_EnterTable_State_ULOCK_AF_SAVE;
    40.         PBUpdateData update;
    41.         update.set_key(PBUserDataField::kUserInfo);
    42.         {
    43.             PBDBAtomicField& field = *update.add_field_list();
    44.             field.set_field(EN_DB_Field_POS);
    45.             PBBPlayerPositionInfo& pos = *field.mutable_pos();
    46.             pos.set_pos_type(EN_Position_Hall);
    47.             pos.set_table_id(0);
    48.             pos.set_gamesvrd_id(0);
    49.         }
    50.         psession->NewAddUpdateData(psession->_request_route.uid(), update);
    51.         return EN_Handler_Save;
    52.     }
    53.     const PBUserTeaBarData& tbdata = psession->_kvdb_uid_data_map[uid].user_tea_bar_data();
    54. 	//竞技场，记录玩家来自哪个亲友圈
    55.     if(ptable->config().is_arena())
    56.     {
    57.         pseat->mutable_src_tea_bar()->set_tbid(cs_request_enter_table.src_tbid());
    58.         pseat->mutable_src_tea_bar()->mutable_tb_master()->set_uid(cs_request_enter_table.src_tb_master_uid());
    59.     }
    60.     TableLogic::SitDownOnTable(*ptable,*pseat,user,tbdata,connect_id);
    61.     CSNotifyTableInfo& info = *response.mutable_table_info();
    62.     TableLogic::CopyTableToNotify(*ptable, info, uid);
    63.     response.set_result(EN_MESSAGE_ERROR_OK);
    64.     response.set_gamesvrd_id(TGlobal::_svid);
    65.     response.set_pos_type(EN_Position_DSS_Xj);
    66.     Message::SendResponseMsg(RouteManager::Instance()->GetRouteByRandom(), psession, msg);
    67.     return EN_Handler_Done;
    68. }

    这个代码抽出来是比较简单，但是要能正常运行并没有那么简单，因为这里还有

    TableLogic::CopyTableToNotify(*ptable, info, uid); TableLogic::FindEmptySeatInTable(*ptable); TableLogic::CopyTableToNotify(*ptable, info, uid);
    三个函数调用，这三个TableLogic也是每个游戏都有一份，，。。代码相识度100%...  同理 CPBGameTable* ptable = TableManager::Instance()->FindTable(tid); 这也是一个相识度100%代码的一个函数调用，是本地的另外一个文件。那么这些代码也必须抽出来

    1.先把消息处理的代码抽出来吧

    Clienthandlerbase.h

    1. //
    2. // Author: baiyufei
    3. // Date: 2022-08-25 15:00:00
    4. // 前端协议的通用处理,防止重复代码
    5. //
    6.  
    7.  
    8. #pragma once
    9. #include "poker_msg.pb.h"
    10. #include "NewProcessor.h"
    11.  
    12. namespace base
    13. {
    14.     enum EN_EenterTable_State
    15.     {
    16.         EN_EnterTable_State_ULOCK = 1,
    17.         EN_EnterTable_State_ENTERING = 2,
    18.         EN_EnterTable_State_ULOCK_AF_SAVE = 3,
    19.     };
    20. }
    21.  
    22. class Clienthandlerbase
    23. {
    24. private:
    25.     /* data */
    26. public:
    27.     Clienthandlerbase(/* args */);
    28.     ~Clienthandlerbase();
    29.     static Clienthandlerbase* Instance() {static Clienthandlerbase gInstance; return &gInstance;}
    30. public:
    31.  
    32.     bool cs_response_dss_enter_table(CSession* psession, PBDSSGameTable** ptable, PBDSSTableSeat** pseat, ENPlayerPositionType gameId);
    33.  
    34. };
    35.  
    36.

    Clienthandlerbase.cpp

    1. #include "Clienthandlerbase.h"
    2. #include "TableMgrbase.h"
    3.  
    4. using namespace base;
    5.  
    6. Clienthandlerbase::Clienthandlerbase(/* args */)
    7. {
    8. }
    9.  
    10. Clienthandlerbase::~Clienthandlerbase()
    11. {
    12. }
    13.  
    14. bool Clienthandlerbase::cs_response_dss_enter_table(CSession* psession, PBDSSGameTable** ptable, PBDSSTableSeat** pseat, ENPlayerPositionType gameId)
    15. {
    16.     if (psession->_fsm_state == EN_EnterTable_State_ULOCK)
    17.     {
    18.         PBCSMsg msg;
    19.         CSResponseDssEnterTable& response = *msg.mutable_cs_response_dss_enter_table();
    20.         response.set_result(EN_MESSAGE_TABLE_NOT_EXIST);
    21.         Message::SendResponseMsg(RouteManager::Instance()->GetRouteByRandom(), psession, msg);
    22.         return false;
    23.     }
    24.     else if (psession->_fsm_state == EN_EnterTable_State_ULOCK_AF_SAVE)
    25.     {
    26.         PBCSMsg msg;
    27.         CSResponseEnterTable& response = *msg.mutable_cs_response_enter_table();
    28.         response.set_result(EN_MESSAGE_NO_EMPTY_SEAT);
    29.         Message::SendResponseMsg(RouteManager::Instance()->GetRouteByRandom(), psession, msg);
    30.         return false;
    31.     }
    32.     const CSRequestDssEnterTable& cs_request_enter_table = psession->_request_msg.cs_request_dss_enter_table();
    33.     int tid = cs_request_enter_table.tid();
    34.     *ptable = TableMgrbase::Instance()->FindTable(tid);
    35.     if(NULL == ptable)
    36.         return false;
    37.     *pseat = TableMgrbase::Instance()->FindEmptySeatInTable(**ptable, cs_request_enter_table.observe());
    38.     if(NULL == pseat)
    39.     {
    40.         psession->_fsm_state = EN_EnterTable_State_ULOCK_AF_SAVE;
    41.         PBUpdateData update;
    42.         update.set_key(PBUserDataField::kUserInfo);
    43.         {
    44.             PBDBAtomicField& field = *update.add_field_list();
    45.             field.set_field(EN_DB_Field_POS);
    46.             PBBPlayerPositionInfo& pos = *field.mutable_pos();
    47.             pos.set_pos_type(EN_Position_Hall);
    48.             pos.set_table_id(0);
    49.             pos.set_gamesvrd_id(0);
    50.         }
    51.         psession->NewAddUpdateData(psession->_request_route.uid(), update);
    52.         return false;
    53.     }
    54.  
    55.     long long uid = psession->_request_route.uid();
    56. 	//竞技场，记录玩家来自哪个亲友圈
    57.     if((**ptable).config().is_arena())
    58.     {
    59.         (**pseat).mutable_src_tea_bar()->set_tbid(cs_request_enter_table.src_tbid());
    60.         (**pseat).mutable_src_tea_bar()->mutable_tb_master()->set_uid(cs_request_enter_table.src_tb_master_uid());
    61.     }
    62.  
    63.     const PBUser& user = psession->_kvdb_uid_data_map[uid].user_info();
    64.     int connect_id = cs_request_enter_table.connect_id();
    65.     const PBUserTeaBarData& tbdata = psession->_kvdb_uid_data_map[uid].user_tea_bar_data();
    66.     TableMgrbase::Instance()->SitDownOnTable(**ptable,**pseat,user,tbdata,connect_id);
    67.  
    68.     PBCSMsg msg;
    69.     CSResponseDssEnterTable& response = *msg.mutable_cs_response_dss_enter_table();
    70.     CSNotifyTableInfo& info = *response.mutable_table_info();
    71.     TableMgrbase::Instance()->CopyTableToNotify(**ptable, info, uid);
    72.     response.set_result(EN_MESSAGE_ERROR_OK);
    73.     response.set_gamesvrd_id(TGlobal::_svid);
    74.     response.set_pos_type(gameId);
    75.     Message::SendResponseMsg(RouteManager::Instance()->GetRouteByRandom(), psession, msg);
    76.  
    77.     return true;
    78. }

    再把 TableLogic和TableManager的代码抽出来形成TableMgrbase

    TableMgrbase.h

    1. //
    2. // Author: baiyufei
    3. // Date: 2022-08-25 15:00:00
    4. // 桌子的通用逻辑(其他游戏的所有桌子数据在这里都有一个指针备份)
    5. //
    6.  
    7. #pragma once
    8. #include "poker_msg.pb.h"
    9. #include 
    10. #include "../core/include/Timer_Handler_Base.h"
    11. using namespace std;
    12. using google::protobuf::RepeatedField;
    13. using google::protobuf::RepeatedPtrField;
    14.  
    15. typedef long long  int64;
    16. typedef int        int32;
    17.  
    18. namespace base
    19. {
    20.     #define  REPORT_AT_PLAY_TIMER 10000
    21.  
    22.     typedef map baseTableMap;
    23.     typedef map           baseUserTableMap;
    24.  
    25.     enum ENGameServiceState
    26.     {
    27.         EN_Game_Service_State_IDEL  = 1,
    28.         EN_Game_Service_State_Connecting = 2,
    29.         EN_Game_Service_State_Registing = 3,
    30.         EN_Game_Service_State_Ready = 4,
    31.         EN_Game_Service_State_Working = 5,
    32.         EN_Game_Service_State_Retired = 6,
    33.     };
    34. }
    35.  
    36. class TableMgrbase 
    37. {
    38. private:
    39.     /* data */
    40. public:
    41.     TableMgrbase(/* args */);
    42.     ~TableMgrbase();
    43.     
    44.     static TableMgrbase* Instance();
    45.  
    46. public:
    47.    void Init();
    48.    PBDSSGameTable* FindTable(int64 tid);
    49.    void ReportGameInfo();
    50. public:
    51.     //如果要用通用的桌子逻辑，其他游戏new桌子的时候一定要调用addTable在这里备份一个数据
    52.     void addTable(int64 tid, PBDSSGameTable* pPBDSSGameTable);
    53.  
    54. public:
    55.     void SitDownOnTable(PBDSSGameTable & table,PBDSSTableSeat & seat,const PBUser & user,const PBUserTeaBarData& tbdata,int connect_id = 1);
    56.     //如果是茶馆房间，刷新下茶馆人数，并且设置备注
    57.     void RefreshTeabarTableDisplay(PBDSSGameTable& table, bool is_need_refesh_play_num);
    58.     void BroadcastTableMsg(const PBDSSGameTable& table, PBCSMsg& notify, int excepted_uid = 0); 
    59.     //找一个空位置
    60.     PBDSSTableSeat* FindEmptySeatInTable(PBDSSGameTable& table, bool observe);
    61.     void CopyTableToNotify(const PBDSSGameTable& table, CSNotifyTableInfo& info, int uid);
    62.     //座位判断与状态统计
    63.     int GetPlayerNumByState(const PBDSSGameTable& table, ENSeatState expected_state);
    64.     PBDSSAction& GetLastActionInFlow(PBDSSGameTable& table);
    65.     const PBDSSAction* GetLastActionInFlow(const PBDSSGameTable& table);
    66.  
    67. public:
    68.  	base::baseTableMap         _tablemap;
    69.     base::ENGameServiceState   _state; 
    70.  
    71. public:
    72.     int64 start_stamp;
    73.  
    74. };
    75.  
    76.

    TableMgrbase.cpp

    1. #include "TableMgrbase.h"
    2. #include "../core/include/global.h"
    3. #include "NewProcessor.h"
    4. #include "RouteManager.h"
    5. #include "global.h"
    6. #include "../svr/common/LogWriter.h"
    7.  
    8. TableMgrbase::TableMgrbase(/* args */)
    9. {
    10. }
    11.  
    12. TableMgrbase::~TableMgrbase()
    13. {
    14. }
    15.  
    16. void TableMgrbase::Init()
    17. {
    18. }
    19.  
    20. TableMgrbase* TableMgrbase::Instance()
    21. {
    22. 	static TableMgrbase gInstance;
    23. 	return &gInstance;
    24. }
    25.  
    26. PBDSSGameTable* TableMgrbase::FindTable(int64 tid)
    27. {
    28.     if (_tablemap.find(tid) == _tablemap.end())
    29.     {
    30.         return NULL;
    31.     }
    32.     PBDSSGameTable* table = _tablemap[tid];
    33.     return table;
    34. }
    35.  
    36. void TableMgrbase::addTable(int64 tid, PBDSSGameTable* pPBDSSGameTable)
    37. {
    38.     if (NULL == pPBDSSGameTable || _tablemap.find(tid) != _tablemap.end())
    39.     {
    40.         return;
    41.     }
    42.      _tablemap[tid] = pPBDSSGameTable;
    43. }
    44.  
    45. void TableMgrbase::ReportGameInfo()
    46. {
    47.     if (_state == base::EN_Game_Service_State_Retired)
    48.     {
    49.         return;
    50.     }
    51.     PBCSMsg msg;
    52.     SSReportGameSvrdInfo& ss_report_gamesvrd_info = *msg.mutable_ss_report_game_info();
    53.     ss_report_gamesvrd_info.set_gameid(TGlobal::_svid);
    54.     ss_report_gamesvrd_info.set_gtype(TGlobal::_svrd_type);
    55.     Message::PushInnerMsg(RouteManager::Instance()->GetRouteByRandom(), 0, msg, EN_Node_Room, 1);
    56. }
    57.  
    58. void TableMgrbase::SitDownOnTable(PBDSSGameTable & table, PBDSSTableSeat & seat, const PBUser & user, const PBUserTeaBarData& tbdata, int connect_id /*= 1*/)
    59. {
    60.     //玩家坐下
    61.     PBTableUser& tableuser = *seat.mutable_user();
    62.     tableuser.set_uid(user.uid());
    63.     tableuser.set_nick(user.nick());
    64.     tableuser.set_role_picture_url(user.pic_url());
    65.     tableuser.set_acc_type(user.acc_type());
    66.     tableuser.set_channel(user.channel());
    67.     tableuser.set_last_login_ip(user.last_login_ip());
    68.     tableuser.set_gender(user.gender());
    69.     tableuser.set_chip(user.chips());
    70.     tableuser.set_connect_id(connect_id);
    71.     tableuser.set_items_info(user.items_info());
    72.     if(tbdata.brief_data_size() > 0)
    73.     {
    74.         for(int i = 0; i < tbdata.brief_data_size(); i++)
    75.         {
    76.             tableuser.mutable_tbid_list()->Add(tbdata.brief_data(i).tbid());
    77.         }
    78.     }
    79.     seat.set_state(EN_SEAT_STATE_WAIT_FOR_NEXT_ONE_GAME);
    80.     seat.set_final_score(0);
    81.     seat.set_total_score(0);
    82. 	if (seat.switch_voices_size() != table.seats_size())
    83.     {
    84.         seat.mutable_switch_voices()->Resize(table.seats_size(), true);
    85.     }
    86.     
    87.     //OnPlayerEnterTable(user.uid(),table.tid());
    88.     //如果是茶馆房间，刷新下茶馆人数，并且设置备注
    89.     if (table.config().has_tbid() && table.config().has_master_uid())
    90.     {
    91.         long long tbid = table.config().tbid();
    92.         if(table.config().is_arena())
    93.         {
    94.             tbid = seat.src_tea_bar().tbid();
    95.         }
    96.         for(int i = 0; i < tbdata.brief_data_size(); i++)
    97.         {
    98.             if(tbid == tbdata.brief_data(i).tbid())
    99.             {
    100.                 tableuser.set_remark(tbdata.brief_data(i).remarks());
    101.                 //设置魅力值
    102.                 if(table.config().has_rpf())
    103.                 {
    104.                     seat.set_bind_cooperator_uid(tbdata.brief_data(i).bind_cooperator_uid());
    105.                     seat.set_charm_score(tbdata.brief_data(i).charm_score() * 100);
    106.                     seat.set_is_hide_charm_score(tbdata.brief_data(i).is_hide_charm_score());
    107.                     ErrMsg("当前魅力值[%ld], uid[%ld], tid[%ld], tbid[%ld]", seat.charm_score(), seat.user().uid(), table.tid(), tbdata.brief_data(i).tbid());
    108.                 }
    109. 				//设置魅力值
    110.                 if(table.config().has_rmf())
    111.                 {
    112.                     int64 rank_score = 0;
    113.                     if(tbdata.brief_data(i).rank_score_info().match_id() == table.config().rmf().match_id())
    114.                     {
    115.                         rank_score = tbdata.brief_data(i).rank_score_info().rank_score();
    116.                     }
    117.                     seat.set_rank_score(rank_score);
    118.                     seat.set_is_hide_charm_score(tbdata.brief_data(i).is_hide_charm_score());
    119.                     VLogMsg(CLIB_LOG_LEV_DEBUG, "当前比赛分[%ld], uid[%ld], tid[%ld], tbid[%ld] tbdata.brief_data(i).rank_score_info().match_id():%d  table.config().has_rmf().match_id():%d ", seat.rank_score(), seat.user().uid(), table.tid(), tbdata.brief_data(i).tbid(),tbdata.brief_data(i).rank_score_info().match_id(), table.config().rmf().match_id());                                        
    120.                 }
    121. 				break;
    122.             }
    123.         }
    124.         RefreshTeabarTableDisplay(table, true);
    125. 	}
    126.     //刷新茶馆玩家游戏状态
    127.     if(tbdata.brief_data_size() > 0)
    128.     {
    129.         PBCSMsg msg_teabar;
    130.         SSNotifyTeaBarUserGameState& teabar_notify = *msg_teabar.mutable_ss_notify_tea_bar_user_game_state();
    131.         teabar_notify.set_uid(user.uid());
    132.         if(table.config().is_arena())
    133.         {
    134.             teabar_notify.set_game_state(3);
    135.         }
    136.         else
    137.         {
    138.             teabar_notify.set_game_state(1);
    139.         }
    140.         teabar_notify.mutable_tbid_list()->CopyFrom(tableuser.tbid_list());
    141.         Message::PushInnerMsg(RouteManager::Instance()->GetRouteByRandom(), 0, msg_teabar, EN_Node_TeaBar, 1);
    142.     }
    143.     //广播玩家坐下
    144.     PBCSMsg msg;
    145.     CSNotifySitDown& notify_sit_down = *msg.mutable_cs_notify_sit_down();
    146.     notify_sit_down.mutable_dss_seat()->CopyFrom(seat);
    147.     BroadcastTableMsg(table, msg, user.uid());
    148.  
    149.     return;
    150. }
    151.  
    152. void TableMgrbase::RefreshTeabarTableDisplay(PBDSSGameTable& table, bool is_need_refesh_play_num)
    153. {
    154. 	//如果是茶馆房间，刷新下茶馆人数，并且设置备注
    155. 	if (table.config().has_tbid() && table.config().has_master_uid())
    156. 	{
    157. 		PBCSMsg notify;
    158. 		SSNotifyTeaBarTablePlayerNum& ss_notify_teabar_table_player_num = *notify.mutable_ss_notify_teabar_table_player_num();
    159. 		ss_notify_teabar_table_player_num.mutable_conf()->CopyFrom(table.config());
    160. 		ss_notify_teabar_table_player_num.set_tid(table.tid());
    161. 		if (is_need_refesh_play_num)
    162. 		{
    163. 			ss_notify_teabar_table_player_num.set_player_num(table.seats_size() - GetPlayerNumByState(table, EN_SEAT_STATE_NO_PLAYER));
    164. 		}
    165. 		for (int i = 0; i < table.seats_size(); i++)
    166. 		{
    167. 			if (table.seats(i).state() == EN_SEAT_STATE_NO_PLAYER)
    168. 				continue;
    169. 			PBTeaBarUser& user = *ss_notify_teabar_table_player_num.add_users();
    170. 			user.set_uid(table.seats(i).user().uid());
    171. 			user.set_name(table.seats(i).user().nick());
    172. 			user.set_url(table.seats(i).user().role_picture_url());
    173. 			user.set_remarks(table.seats(i).user().remark());
    174. 			user.set_is_online(!table.seats(i).user().is_offline());
    175. 			user.set_total_score(table.seats(i).total_score());
    176. 		}
    177. 		ss_notify_teabar_table_player_num.set_round(table.round());
    178. 		Message::PushInnerMsg(RouteManager::Instance()->GetRouteByRandom(), 0, notify, EN_Node_TeaBar, 1);
    179. 	}
    180. 	return;
    181. }
    182.  
    183. void TableMgrbase::BroadcastTableMsg(const PBDSSGameTable& table, PBCSMsg& notify, int excepted_uid)
    184. {
    185.     for (int i = 0; i < table.seats_size(); i++)
    186.     {
    187.         const PBDSSTableSeat& seat = table.seats(i);
    188.         if (seat.state() == EN_SEAT_STATE_NO_PLAYER)
    189.         {
    190.             continue;
    191.         }
    192.         const PBTableUser& user = seat.user();
    193.         if (user.uid() != excepted_uid && user.is_offline() == false)
    194.         {
    195.             VLogMsg(CLIB_LOG_LEV_DEBUG, "broadcast msg[0x%x] to user[%ld].seat index[%d]", notify.msg_union_case(), user.uid(), i);
    196.             {
    197.                 Message::PushMsg(RouteManager::Instance()->GetRouteByRandom(), seat.user().uid(), notify, EN_Node_Connect, seat.user().connect_id());
    198.             }
    199.         }
    200.     }
    201. }
    202.  
    203. PBDSSTableSeat* TableMgrbase::FindEmptySeatInTable(PBDSSGameTable& table, bool observe)
    204. {
    205.     PBDSSTableSeat* pSeat = NULL;
    206.     if(observe)
    207.     {
    208.         pSeat = table.add_observe();
    209.         pSeat->set_observe(true);
    210.         return pSeat;
    211.     }
    212.  
    213.     for (int i = 0; i < table.seats_size(); i++)
    214.     {
    215.         PBDSSTableSeat& seat = *table.mutable_seats(i);
    216.         if (seat.state() == EN_SEAT_STATE_NO_PLAYER)
    217.         {
    218.             pSeat = & seat;
    219.             pSeat->set_observe(false);
    220.             break;
    221.         }
    222.     }
    223.     return pSeat;
    224. }
    225.  
    226. void TableMgrbase::CopyTableToNotify(const PBDSSGameTable& table, CSNotifyTableInfo& info, int uid)
    227. {
    228.     for (int i = 0; i < table.seats_size(); i++)
    229.     {
    230.         PBDSSTableSeat& seat = *info.add_dss_seats();
    231.         seat.CopyFrom(table.seats(i));
    232.         if (seat.user().is_offline())
    233.         {
    234.             seat.set_offline_timer(time(NULL) - seat.offline_time());
    235.         }
    236.         if (seat.state() != EN_SEAT_STATE_NO_PLAYER && seat.user().uid() != uid)
    237.         {
    238.             for (int j = 0; j < seat.hand_cards_size(); j++)
    239.             {
    240.                 seat.set_hand_cards(j, 0);
    241.             }
    242.             seat.clear_action_choice();
    243.         }
    244. 		seat.clear_switch_voices();
    245.     }
    246.     for(int i = 0;iseats_size();i++)
    247.     {
    248.         if(table.seats(i).state()!=EN_SEAT_STATE_NO_PLAYER && table.seats(i).user().uid() == uid)
    249.         {
    250.             info.mutable_self_switch_voices()->CopyFrom(table.seats(i).switch_voices());
    251.         }
    252.     }
    253.     info.mutable_out_cards()->CopyFrom(table.out_cards());
    254.     info.set_display_anpai(table.display_anpai());
    255.     info.set_state(table.state());
    256.     info.set_round(table.round());
    257.     if (table.dealer_index_2() != -1)
    258.     {
    259. 		RepeatedField<int> di_src;
    260. 		for (int i = 0; i < table.cards_size() && i < 3; i++)
    261. 		{
    262. 			di_src.Add(table.cards(i));
    263. 		}
    264.         info.mutable_cards()->CopyFrom(di_src);
    265.     }
    266.     else
    267.     {
    268.          int zhua_cards_size = table.config().lai_zi_num() > 0 ? 4 : 3;
    269.          info.mutable_cards()->Resize(zhua_cards_size, 0);
    270.     }
    271.     if (table.total_action_flows_size() > 0)
    272.     {
    273.         for (int i = table.total_action_flows_size() - 1; i >= 0; i--)
    274.         {
    275.             if (table.total_action_flows(i).action().act_type() == EN_DSS_ACTION_PASS
    276.                     && table.total_action_flows(i).action().is_single_over())
    277.             {
    278.                 for (int j = i + 1; j < table.total_action_flows_size(); j++)
    279.                 {
    280.                     info.add_dss_total_action_flows()->CopyFrom(table.total_action_flows(j));
    281.                 }
    282.                 break;
    283.             }
    284.             if (i == 0 && info.dss_total_action_flows_size() == 0)
    285.             {
    286.                 for (int j = 0; j < table.total_action_flows_size(); j++)
    287.                 {
    288.                     if (table.total_action_flows(j).action().act_type() == EN_DSS_ACTION_QIANG_DI_ZHU
    289.                             || table.total_action_flows(j).action().act_type() == EN_DSS_ACTION_BU_QIANG)
    290.                     {
    291.                         if (table.state() == EN_TABLE_STATE_WAIT_QIANG_DI_ZHU)
    292.                         {
    293.                             info.add_dss_total_action_flows()->CopyFrom(table.total_action_flows(j));
    294.                         }
    295.                     }
    296.                     else
    297.                     {
    298.                         info.add_dss_total_action_flows()->CopyFrom(table.total_action_flows(j));
    299.                     }
    300.                 }
    301.             }
    302.         }
    303.         if (info.dss_total_action_flows_size() > 0)
    304.         {
    305.             if (!info.dss_total_action_flows(info.dss_total_action_flows_size() - 1).action().has_col_info())
    306.             {
    307.                 info.mutable_dss_total_action_flows()->RemoveLast();
    308.             }
    309.         }
    310.     }
    311.     info.set_xiaojia_index(table.xiaojia_index());
    312.     info.set_dealer(table.dealer_index());
    313.     if (table.dealer_index_2() == -1)
    314.     {
    315.         info.set_dealer(-1);
    316.     }
    317.     info.set_tid(table.tid());
    318.     info.mutable_dss_conf()->CopyFrom(table.config());
    319.     info.set_creator_uid(table.creator_uid());
    320.     info.set_left_card_num(table.cards_size());
    321.     info.set_operation_index(table.operation_index());
    322.     if (table.has_dissolve_info())
    323.     {
    324.         info.mutable_dissolve_info()->CopyFrom(table.dissolve_info());
    325.     }
    326.     {
    327.         const PBDSSAction* paction = GetLastActionInFlow(table);
    328.         if (paction != NULL)
    329.         {
    330.             if (paction->act_type() == EN_DSS_ACTION_NAPAI)
    331.             {
    332.                 info.set_is_mopai(true);
    333.             }
    334.             info.set_dest_card(paction->dest_card());
    335.             // 只有出牌和拿牌的时候才需要传 dest_card
    336.             if (paction->act_type() != EN_DSS_ACTION_NAPAI && paction->act_type() != EN_DSS_ACTION_CHUPAI)
    337.             {
    338.                 info.set_dest_card(0);
    339.             }
    340.         }
    341.     }
    342. }
    343.  
    344. int TableMgrbase::GetPlayerNumByState(const PBDSSGameTable& table, ENSeatState expected_state)
    345. {
    346.     int num = 0;
    347.     for (int i = 0; i < table.seats_size(); i++)
    348.     {
    349.         const PBDSSTableSeat& seat = table.seats(i);
    350.         if (seat.state() == expected_state)
    351.         {
    352.             num ++ ;
    353.         }
    354.     }
    355.     return num;
    356. }
    357.  
    358. PBDSSAction& TableMgrbase::GetLastActionInFlow(PBDSSGameTable& table)
    359. {
    360.     PBDSSActionFlow& current_flow = *table.mutable_total_action_flows(table.total_action_flows_size() - 1);
    361.     PBDSSAction& current_action = *current_flow.mutable_action();
    362.     return current_action;
    363. }
    364.  
    365. const PBDSSAction* TableMgrbase::GetLastActionInFlow(const PBDSSGameTable& table)
    366. {
    367.     if (table.total_action_flows_size() > 0)
    368.     {
    369.         const PBDSSActionFlow& current_flow = table.total_action_flows(table.total_action_flows_size() - 1);
    370.         const PBDSSAction& current_action = current_flow.action();
    371.         return ¤t_action;
    372.     }
    373.     return NULL;
    374. }

    这样消息处理三个本地调用的三个函数，
    找桌子  CPBGameTable* ptable = TableManager::Instance()->FindTable(tid); 
    找位置 PBDSSTableSeat* pseat = TableLogic::FindEmptySeatInTable(*ptable);，
    坐下 TableLogic::SitDownOnTable(*ptable,*pseat,user,tbdata,connect_id);
    的逻辑都抽在TableMgrbase类里面了。

    其实这里开始遇到一个难点，我抽出来了后，每个游戏都跑这个代码，那么 TableManager::Instance()->FindTable(tid); 必然是每个游戏自己的table，我一个抽象出来的类怎么兼容110个游戏对象？
    游戏的table类

    1. class CPBGameTable : public PBDSSGameTable, public CTimerOutListener
    2. {
    3. public:
    4.     CPBGameTable(const CPBGameTable& table)
    5.     {
    6.         CopyFrom(table);
    7.     }
    8.     CPBGameTable();
    9.     ~CPBGameTable();

    看他这个 CPBGameTable都是继承的同一个基类，那么我们封装的接口就是用的基类。我们去看看他的基类

    1. class PBDSSGameTable : public ::google::protobuf::Message {
    2.  public:
    3.   PBDSSGameTable();
    4.   virtual ~PBDSSGameTable();
    5.  
    6.   PBDSSGameTable(const PBDSSGameTable& from);
    7.  
    8.   inline PBDSSGameTable& operator=(const PBDSSGameTable& from) {
    9.     CopyFrom(from);
    10.     return *this;
    11.   }

    对你没看错，这个基类居然是一个protobuf。那么这个基类是不能自定义函数了。。。。
    那么就是抽象出来的通用接口，只能用基类的数据做逻辑处理，是不能函数调用的，但是我们通用的消息处理那是确实用到了函数调用
    ptable->StopReadyTimer(); ptable->StartReadyTimer(120);怎么办？我们调用基类处理通用逻辑，然后把对象返回，在通用消息处理后把对象强转成子类对象再调用这二个函数。
    所以最终我们优化后的消息处理就改成这样了

    CommonClienthandler.cpp

    1. ENHandlerResult CRequestEnterTable::ProcessUpdateSucc(CHandlerTokenBasic* ptoken, CSession* psession)
    2. {
    3.     PBDSSGameTable *pPBDSSGameTable = NULL ; PBDSSTableSeat *pseat = NULL;
    4.     if(!Clienthandlerbase::Instance()->cs_response_dss_enter_table(psession, &pPBDSSGameTable, &pseat, EN_Position_DDZ_AY_3))
    5.         return EN_Handler_Done;
    6.     CPBGameTable* ptable = (CPBGameTable*)pPBDSSGameTable;
    7.     TableManager::Instance()->OnPlayerEnterTable(psession->_request_route.uid(), ptable->tid());
    8.     ptable->StopReadyTimer();
    9.     ptable->StartReadyTimer(120);
    10.     return EN_Handler_Done;
    11. }

    我们现在来算算这个优化删掉了多少代码
    消息处理函数
    ENHandlerResult CRequestEnterTable::ProcessUpdateSucc(CHandlerTokenBasic* ptoken, CSession* psession)
    原本68行代码
    优化后11行代码
    看起来消息处理这里只优化了57行？
    你忘了消息处理这里还有函数调用
    PBDSSGameTable* TableMgrbase::FindTable(int64 tid)  9行
    PBDSSTableSeat* TableMgrbase::FindEmptySeatInTable(PBDSSGameTable& table, bool observe) 22行
    TableMgrbase::Instance()->SitDownOnTable(**ptable,**pseat,user,tbdata,connect_id);  92行
     
    SitDownOnTable里面还有函数调用
    RefreshTeabarTableDisplay(table, true);     30行
    BroadcastTableMsg(table, msg, user.uid());  38行

    函数调用一共191行，加上消息处理68行 ，之前是多少行代码？(68+191)*110=28490行
    现在多少行？11*110 +191 = 1401行代码
     

  • 相关阅读:
    轻松学会JavaScript事件
    HTML语义化标签（一）
    【Linux】进程控制 （万字详解）—— 进程创建 | 进程退出 | 进程等待 | 程序替换 | 实现简易shell
    EasyExcel复杂表头导出（一对多）升级版
    JAVA【DAO及其实现类】
    解决大众D评网站css加密改进说明
    并发编程带来的安全性挑战之同步锁
    【位运算】只出现一次的数字
    ElementUI之动态树+数据表格+分页
    【EPLAN】统一修改项目中字体大小
  • 原文地址：https://blog.csdn.net/q277055799/article/details/126623589